Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
36 stars 1 forks source link

Add navigation bar to the avatar picker #358

Closed pinarol closed 4 weeks ago

pinarol commented 1 month ago

Closes #343

Description

Adds navigation bar. I used NavigationView for now since it is supported in iOS 15. NavigationStack is supported only for iOS 16+.

Updates the "Discover Your Gravatar Card" to "View profile" based on designs. Ties the action to open the profile in Safari.

Refactors some of the paddings based on the designs.

Testing Steps

wpmobilebot commented 1 month ago
Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1118
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit4a4dd0b8d4fefcdd2b31810b8c5da850627895ce
App Center BuildGravatar SDK Demo - UIKit #54
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 month ago
Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1118
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commit4a4dd0b8d4fefcdd2b31810b8c5da850627895ce
App Center BuildGravatar SDK Demo - SwiftUI #53
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
pinarol commented 4 weeks ago

I liked "fullScreenCover" better. 👍 For now it seems like the best we can get out of SwiftUI about this.