Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
41 stars 5 forks source link

Quick Editor: Add presentation styles #377

Closed pinarol closed 1 month ago

pinarol commented 2 months ago

Closes https://github.com/Automattic/Gravatar-SDK-iOS/issues/376

Description

We allow passing presentationDetents. Unfortunately they are supported only + iOS16 so I had to duplicate some code :(

Introduces different presentation styles.

Pre iOS 16

iOS 16.0 +

https://github.com/user-attachments/assets/9bd85995-9312-4d9b-bedd-a22f38c98449

https://github.com/user-attachments/assets/718ceb3d-8adc-4255-b8b4-7b40ebe5862c


If the width is not compact(like in iPads) the system displays a full height sheet so we always show the vertical grid:

Simulator Screenshot - iPad mini (6th generation) - 2024-09-05 at 15 13 44

Testing Steps

SwiftUI demo app > Avatar picker view > select different layout options.

wpmobilebot commented 2 months ago
Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1205
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commitf6cf927df3f973b6ee1f068c253507d3af887e20
App Center BuildGravatar SDK Demo - UIKit #101
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 2 months ago
Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1205
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commitf6cf927df3f973b6ee1f068c253507d3af887e20
App Center BuildGravatar SDK Demo - SwiftUI #100
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
pinarol commented 2 months ago

I think this is ready for review. @etoledom