search

Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
36 stars 1 forks source link

Remove async from ImageCaching #385

Closed kean closed 1 week ago

kean commented 1 week ago

This PR removes the async requirement from the ImageCaching protocol so that the clients could use it from synchronous contexts.

Description

Testing Steps

kean commented 1 week ago

Converting to draft as the tests implement the caching protocol using an actor, which has to be asynchronous.

pinarol commented 1 week ago

Fixed the CI issue here https://github.com/Automattic/Gravatar-SDK-iOS/pull/386, so i am closing this one in favor of that PR.