search

Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
41 stars 5 forks source link

Use `ImageCache.shared` as the default value #387

Closed pinarol closed 1 month ago

pinarol commented 2 months ago

Closes #

Description

ImageDownloadService defaults to ImageCache() when the passed cache is nil. It should be ImageCache.shared. Fortunately we pass here ImageCache.shared in many places so there's no real bug reported about this. But this is still worth a patch release.

Testing Steps

Smoke testing the UIKit demo app.

pinarol commented 1 month ago

Any particular reason the OR is on a Draft?

Nope. Just forgotten.