search

Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
41 stars 5 forks source link

Merge Localizations #412

Closed andrewdmontgomery closed 1 month ago

andrewdmontgomery commented 1 month ago

Closes #

Description

Note: in the Photo Picker, the Choose a Photo and Take a Photo strings are not yet localized. Those are handled in a separate PR: #400

Testing Steps

Necessary Tests

For the Curious

If you're curious, you can check out various localizations. However, any localization bugs will be handled in a separate PR.

  1. Update the App Language for each scheme image
  2. Run using each scheme
  3. Check out various views

Note: Most of the time, you should ignore missing localizations for any Navigation bar items. They will only be localized if the strings are localized by the parent view, which is usaully (but not always) the Demo app. We do not provide any localized strings in the Demo app. There are times, though, where we we use system labels (such as .done). In those cases, they will appear localized.

Note: The exception to that rule is the Profile editor with oauth view. The Done button here is provided by the SDK, and should be localized.

wpmobilebot commented 1 month ago
Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1299
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commita1bf5162a57f4cdbe4a2af4d9a4b80bc1769029a
App Center BuildGravatar SDK Demo - SwiftUI #153
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 month ago
Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1299
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commita1bf5162a57f4cdbe4a2af4d9a4b80bc1769029a
App Center BuildGravatar SDK Demo - UIKit #154
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
andrewdmontgomery commented 1 month ago

@etoledom I updated the description to limit the required testing. It just needs to pass CI.

Before we release, we'll want to QA the layouts, etc. But this PR is just to merge in the localizations. The QA should be handled separately.