Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
52 stars 5 forks source link

QE OAuth: Ignore the cancelled error so it doesn't override our current error #432

Closed pinarol closed 1 month ago

pinarol commented 2 months ago

Closes https://github.com/Automattic/Gravatar-SDK-iOS/issues/431

Description

We start to detect if the user has cancelled the oauth flow and treat it just like a dismissal of the OAuth flow so we ignore the error and the previous state remains same.

Testing Steps

SwiftUI Demo app > Profile editor with OAuth Follow the steps here https://github.com/Automattic/Gravatar-SDK-iOS/pull/427 to see the wrong email error Restart the oauth flow but this time tap cancel Observe: The same wrong email error remains

cc: @hamorillo

wpmobilebot commented 2 months ago
Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1339
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commite1c52159ac5a91d9875bb422e3f92f5ebcfdbc23
App Center BuildGravatar SDK Demo - UIKit #179
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 2 months ago
Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1339
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commite1c52159ac5a91d9875bb422e3f92f5ebcfdbc23
App Center BuildGravatar SDK Demo - SwiftUI #178
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.