Automattic / Gravatar-SDK-iOS

Gravatar SDK is a Swift library that allows you to integrate Gravatar features into your own iOS applications.
https://gravatar.com
Mozilla Public License 2.0
52 stars 5 forks source link

Make HTTPClient internal #482

Closed pinarol closed 1 month ago

pinarol commented 1 month ago

Closes part of #449

Description

Making HTTPClient internal since a custom HTTPClient implementation will not work properly anyway. This is mostly because of how we handle and map errors. There's still a way to mock the URLSession via URLSessionProtocol.

Testing Steps

Smoke test:

SwiftUI demo app > Profile editor with oauth UIKit demo app > Profile cards

wpmobilebot commented 1 month ago
Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1456
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commit2c2062a22cbda62284d2cda7a9101fbea17d5dd7
App Center BuildGravatar SDK Demo - SwiftUI #245
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 month ago
Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1456
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit2c2062a22cbda62284d2cda7a9101fbea17d5dd7
App Center BuildGravatar SDK Demo - UIKit #245
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.