search

Automattic / Gridicons-iOS

Gridicons is a tiny framework which generates Gridicon images at any resolution.
GNU General Public License v2.0
25 stars 12 forks source link

Update the filter icon #36

Closed mindgraffiti closed 5 years ago

mindgraffiti commented 5 years ago

In this PR, the filter icon changes from a funnel to a 3-line symbol. The filter icon was updated here: https://github.com/Automattic/gridicons/pull/295. Testing instructions included for whichever host app you prefer. Testing on both apps is not required.

cc: @bummytime

44091089-3d8796c4-9fc4-11e8-8ed4-582cf8d31ea7

To test, using WCiOS

  1. Check out this WCiOS PR: https://github.com/woocommerce/woocommerce-ios/pull/609.
  2. Navigate to the Orders tab.
  3. Look at the nav bar's top right button.
  4. Verify the filter icon looks like the one listed above, on the right.

To test, using WPiOS

  1. Add the .filter icon to a known gridicon UI.
  2. Point the podfile to pod 'Gridicons', :git => 'https://github.com/Automattic/Gridicons-iOS.git', :branch => 'feature/filter-icon-update'
  3. pod update Gridicons
  4. Run the app and verify the icon looks like 3 lines.
mindgraffiti commented 5 years ago

Thanks @danielebogo!