Automattic / Gridicons-iOS

Gridicons is a tiny framework which generates Gridicon images at any resolution.
GNU General Public License v2.0
25 stars 12 forks source link

Use PDF assets instead of auto-generated drawing code #46

Closed frosty closed 4 years ago

frosty commented 4 years ago

This PR updates Gridicons to use PDF assets with vector data instead of auto-generated drawing code. The previous system was awkward to update and required people to use third party Mac software to update the library. The new system uses an asset catalog containing PDFs straight from the main Gridicons repo, and SwiftGen to generate an enum referencing the assets in the catalog.

I know this is a huge changeset, but it's primarily because of the removal of the old autogenerated code, and the addition of the new Xcode-created asset catalog.

I would like to bump the pod version to 1.0 when these changes are released, but I'll do that separately as it'll require updating other pods that depend on a 0.x version of Gridicons.

To test

frosty commented 4 years ago

Thanks both! @jkmassel the newlines are definitely a thing, I just remembered I deleted them in my version to tidy it up a little. I just pushed a tweak to remove the newlines, and I'll merge once ci is 🍏. Thanks for addressing the ruby config!