Closed frosty closed 4 years ago
Thanks both! @jkmassel the newlines are definitely a thing, I just remembered I deleted them in my version to tidy it up a little. I just pushed a tweak to remove the newlines, and I'll merge once ci is 🍏. Thanks for addressing the ruby config!
This PR updates Gridicons to use PDF assets with vector data instead of auto-generated drawing code. The previous system was awkward to update and required people to use third party Mac software to update the library. The new system uses an asset catalog containing PDFs straight from the main Gridicons repo, and SwiftGen to generate an enum referencing the assets in the catalog.
I know this is a huge changeset, but it's primarily because of the removal of the old autogenerated code, and the addition of the new Xcode-created asset catalog.
I would like to bump the pod version to 1.0 when these changes are released, but I'll do that separately as it'll require updating other pods that depend on a 0.x version of Gridicons.
To test
rake dependencies
and ensure SwiftGen is installed successfullyrake gen
and ensure that there are no major changes from the currentGridiconsGenerated.swift
file (you could try clearing that file first and ensure it's regenerated correctly).