Automattic / Gridicons-iOS

Gridicons is a tiny framework which generates Gridicon images at any resolution.
GNU General Public License v2.0
25 stars 12 forks source link

Add Buildkite #63

Closed jkmassel closed 3 years ago

jkmassel commented 3 years ago

Adds Buildkite support alongside CircleCI – also removes the CircleCI-based publishing and:

To Test

jkmassel commented 3 years ago

For this project, we use the Rakefile to manage the swiftgen stuff, so realistically it could live anywhere – even just as a target within the Xcode project?

IMHO that change would be great as part of a "remove ruby from all non-CI work" update – I think we could probably accomplish all the same using SwiftPM + a bash script target?

mokagio commented 3 years ago

IMHO that change would be great as part of a "remove ruby from all non-CI work" update – I think we could probably accomplish all the same using SwiftPM + a bash script target?

I'm not sure about SPM + bash script target, but mainly because I'm not familiar with how SwiftGen works and how it's used here.

Definitely makes sense to tackle it as part of a Ruby removal, when or if the time will come for that. 👍

AliSoftware commented 3 years ago

We can definitively move the stuff in Rakefile elsewhere (in a separate PR).

I'm not sure about SPM + bash script target, but mainly because I'm not familiar with how SwiftGen works and how it's used here.

The things that the Rakefile handles here are mainly "check if SwiftGen is installed (in the expected version)", "install it if not", and "invoke it". All those should totally be doable via simple shell commands or fastlane lanes instead.

In fact that logic and those steps is pretty much similar to the ones I've implemented in my ios_lint_localizations action in the toolkit (in that action we're using SwiftGen to compare placeholder types used strings files, while in GridIcons we're using SwiftGen for its primary purpose, which is generate type-safe Swift constants for each asset/icon that library contains)

mokagio commented 3 years ago

Maybe we could extra the logic to check and install SwiftGen in a dedicated release toolkit action 🤔 🧐

That could actually be a neat standalone Fastlane plugin, too.

mokagio commented 3 years ago

@jkmassel I can see the branch still exists. I'm 99% we can deleted, so I'll go ahead and do it, and turn on automatic branch deletion in this repo.

Let me know if I missed something and there was a reason to keep the branch: 🙏