search

Automattic / Gridicons-iOS

Gridicons is a tiny framework which generates Gridicon images at any resolution.
GNU General Public License v2.0
25 stars 12 forks source link

Updates the recommended settings, and lowers the deployment target. #7

Closed diegoreymendez closed 8 years ago

diegoreymendez commented 8 years ago

This PR updates the recommended settings for Xcode 8.0 and lowers the deployment target to 9.0 (in line with the deployment target we have for WPiOS and other libraries).

How to test:

Make sure the library builds without errors.

Review:

I'm assigning to several people so that whoever sees this first can review it. The deployment target change is particularly necessary for Carthage integration of this library into Aztec (we're running a test with Carthage).

CocoaPods seems to override the deployment target for the project files it generates, which is the reason why this wasn't a problem when using it.

jleandroperez commented 8 years ago

Hey there @diegoreymendez,

Xcode still suggests me to update few things. Is it possible you didn't push another commit?

Thanks!!

screen shot 2016-09-16 at 10 43 43
diegoreymendez commented 8 years ago

@jleandroperez - I'm not sure why it's doing that, but I had updated the settings. 100% sure.

In any case, please apply the recommended changes and upload them to this PR so we can move ahead. It feels to me like he issue could be related to CocoaPods but I'm not 100% sure.

jleandroperez commented 8 years ago

:shipit: