search

Automattic / HyperDB

HyperDB is an advanced database class that supports replication, failover, load balancing, and partitioning.
104 stars 22 forks source link

Add a connect timeout explicitly to hyperdb. #129

Open dd32 opened 1 year ago

dd32 commented 1 year ago

Add a connect timeout explicitly to wpdb. While this generally has the same effect as the default_socket_timeout ini setting, but hopefully in future PHPs it would apply to the whole handshake.

While upgrading HyperDB on WordPress.org, I spotted that we have a customization on WordPress.org & WordPress.com that hasn't been added to HyperDB on GitHub.

It initially appears that this might be a bugfix that doesn't apply to HyperDB directly with currently released versions of PHP, but as I can't see any harm in upstreaming this, and can't find any open PHP Bugs seemingly related to it, I'm PR'ing it here for reference and determinations.

@vnsavage I've requested review from you as you're the original author. Is this something that is safe to merge to HyperDB? Or should it be kept as a customization on the platforms?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

vnsavage commented 1 year ago

You are correct - that change doesn't do anything without a bug fix on the PHP side which we have on WP.com/WP.org. There is a pull requests pending here: https://github.com/php/php-src/pull/9532