search

Automattic / HyperDB

HyperDB is an advanced database class that supports replication, failover, load balancing, and partitioning.
104 stars 22 forks source link

Flush the query results variables following strip_invalid_text_from_query() #130

Open dd32 opened 1 year ago

dd32 commented 1 year ago

Flush the query results variables following strip_invalid_text_from_query() to ensure queries from that function does not get returned to the caller function.

This changeset to wpdb was never added to to HyperDB.

18 months ago I merged it to our HyperDB on WordPress.org, but appear to have failed to create a PR here, and don't recall what I was fixing at the time. It appears it was likely causing PHP Notices somehow or causing problems in the WordPress.org stats.

Based on the core bug it was fixing, it appears it may also affect some unit tets.

@pento I don't suppose you recall any details of the above changeset, and if/why/not it should be added to HyperDB too?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication