search

Automattic / Picard

A prototype theme that uses React and WP-API
629 stars 110 forks source link

Update readme to specify requiring the v2 REST API plugin from the Wo… #38

Closed kwight closed 9 years ago

kwight commented 9 years ago

…rdPress.org plugin repo.

There is now a v2 REST API plugin in the plugin repo. For the sake of simplicity and stability, we could build Picard on top of this plugin, and avoid devs having to deal with a beta repo (or getting tripped up by the project's master vs develop branches).

jacklenox commented 9 years ago

Thanks Kirk, I wonder if this could just be included in the v2 PR – #37 – that we already have?

jacklenox commented 9 years ago

I believe WP-API's master branch is actually still v1. But you raise a good point here.

For the sake of ease, I have made the modifications in #37 against the plugin on the dotorg repo.

kwight commented 9 years ago

Indeed, many versions flying around.

For the sake of ease, I have made the modifications in #37 against the plugin on the dotorg repo.

Oh, well that's simple then; want me to just move this commit to #37?

jacklenox commented 9 years ago

Cool, yeah if that makes sense to you? Either that or this PR needs to explicitly depend on #37 methinks.

kwight commented 9 years ago

Closing in favour of 3cafbd2fc30fd8368a04e6e6172ab61460ba5cfd on #37.