search

Automattic / Simplenote-United

Coordinating Simplenote development across its multiple platforms.
10 stars 4 forks source link

While note is (un)published, changes to pinned/MD states are discarded #124

Open pachlava opened 3 years ago

pachlava commented 3 years ago

This probably existed for a long time, but became much easier to notice with the introduction of a new note Actions panel on Electron. Same can be reproduced on iOS too.

Harder to see on macOS and Android because the respective popups are getting closed on tap/click.

Expected

Pinned / Markdown states changed by the user should not be affected by note (un)publishing.

Observed

Note (un)publishing takes some time to complete. If the user changes the pinned/MD states while (un)publishing happens, the changes will be discarded:

Electron: https://user-images.githubusercontent.com/73365754/115392281-0fd4fa80-a1e9-11eb-80e3-1af41c251988.mov

iOS: https://user-images.githubusercontent.com/73365754/115399741-2ed78a80-a1f1-11eb-89a0-5ea185209faa.mov

Reproduced

  1. Open any note
  2. Start its publishing
  3. While it happens, click 'Pin' or 'Markdown' box ~> the state will be reverted as soon as publishing is complete.

Where did you see the bug

Make Model iOS Version App Version
MBP 16” Parallels Desktop Windows 10 Home 20H2 2.10.0-beta1
iPhone XR 14.4.2 4.35.0.0
sandymcfadden commented 3 years ago

This appears to be the same issue described in the PR that introduced the new note Actions panel in Electron. This has to do with updates to the note coming back from GAE. The timing can be off and GAE will send an update basically undoing one of the changes in-app.