search

Automattic / T3

GNU General Public License v3.0
1 stars 0 forks source link

Updated pull request template #2

Closed aaronjbaptiste closed 1 month ago

aaronjbaptiste commented 1 month ago

Summary

I've updated the PR template, it looks like this.

Solution

Updated .github/PULL_REQUEST_TEMPLATE.md

Testing steps

Code review only

Reviewing tips

🧁 Request a review to team chrysalis to assign a random team member.

🔄 Feel free to ping the team name again to "re-roll" if you're unavailable.

🚀 For now there is no requirement on getting review approvals before merging.

aaronjbaptiste commented 1 month ago

Looks good to me. My only question is: who pings the team name again if you're unavailable? the person who was assigned to review?

I've removed the "youre" to make it more generic, either person can add another reviewer.

There is a way to sync github with afk tool also, i'll send a link to slack!