search

Automattic / VIP-Coding-Standards

PHP_CodeSniffer ruleset to enforce WordPress VIP coding standards.
https://wpvip.com/documentation/how-to-install-php-code-sniffer-for-wordpress-com-vip/
Other
236 stars 40 forks source link

Remove WordPressVIPMinimum.Variables.VariableAnalysis #496

Closed GaryJones closed 1 year ago

GaryJones commented 4 years ago

What problem would the enhancement address for VIP?

Since VIPCS 3.0 is a major release with breaking changes, we can remove the deprecated WordPressVIPMinimum.Variables.VariableAnalysis sniff completely.

Describe the solution you'd like

Remove the relevant sniff files, test files, ruleset test snippets and corresponding violation line references, and the ruleset XML references.

GaryJones commented 1 year ago

Per #612:

Action plan suggestion:

  • Deprecate the sniff in the next release (2.x) by:
    • Adding a deprecation warning to the sniff which will inform people to remove the sniff reference from their own custom ruleset.
    • Silencing all messages from the sniff from within the VIPMinimum ruleset, effectively removing the sniff already for people using the standard rulesets.
  • Remove the actual sniff in the next major, i.e. 3.0.0.