search

Automattic / VIP-Coding-Standards

PHP_CodeSniffer ruleset to enforce WordPress VIP coding standards.
https://wpvip.com/documentation/how-to-install-php-code-sniffer-for-wordpress-com-vip/
Other
237 stars 40 forks source link

Composer: allow for the 1.0.0 version of the Composer PHPCS plugin #738

Closed jrfnl closed 1 year ago

jrfnl commented 1 year ago

The Composer PHPCS plugin has released its 1.0.0 version. :tada:

Important: I've widened the version constraints for the plugin, instead of bumping it.

The reason for this is to prevent conflicts with end-user projects/other external PHPCS standards which may also require(-dev) the plugin, but may not (yet) have updated their constraints for the plugin. If the version would have been bumped instead of widened, those users would get an unsolvable conflict during the composer install run (unless they require-dev the plugin for the root project, but then, that's exactly what we don't want them to do as external standards managing the versions of the plugins should be more reliable).

The version constraints now set cover all released versions which support external standards properly.

Ref: https://github.com/PHPCSStandards/composer-installer/releases/tag/v1.0.0

kasparsd commented 1 year ago

Thanks for the fix!

Is there a plan to release a stable version with these changes? It appears that the current diff is relatively small https://github.com/Automattic/VIP-Coding-Standards/compare/2.3.3..22733aa560f0f8855b848475770e4f800157e7f4 and contains mostly dev related changes.

GaryJones commented 1 year ago

Is there a plan to release a stable version with these changes?

We're looking into that.