search

Automattic / VIP-Coding-Standards

PHP_CodeSniffer ruleset to enforce WordPress VIP coding standards.
https://wpvip.com/documentation/how-to-install-php-code-sniffer-for-wordpress-com-vip/
Other
237 stars 40 forks source link

Composer: Update script names #741

Closed GaryJones closed 1 year ago

GaryJones commented 1 year ago

Better align with suggested script names at https://github.com/php-pds/composer-script-names, add script descriptions, and remove a redundant script for manually updating the list of installed code standards into PHPCS.

GaryJones commented 1 year ago

While I'm not adverse to these changes, it's unclear to me why the php-pds/composer-script-names repo is cited as an authoritative document. Based on the commit history, lack of discussion in issues or PRs, the "rules" stated in that repo sound like one-man's opinion.

The research suggests that it was done with analysis on 36,000+ packages, so while not authoritative in the form of it being from Composer or PHP-FIG, it indicates to me that the names proposed in this PR are better aligned with many other Composer script names in PHP packages in the community.

jrfnl commented 1 year ago

@GaryJones I'll have a read through the research, don't have time for it right at this moment.