search

Automattic / WP-Job-Manager

Manage job listings from the WordPress admin panel, and allow users to post jobs directly to your site.
https://wpjobmanager.com
GNU General Public License v3.0
901 stars 368 forks source link

Job filters layout enforced to be on two rows #1794

Open andreilupu opened 5 years ago

andreilupu commented 5 years ago

Hey,

I've noticed that in 1.33.0 the job-filters.php template got this line:

https://github.com/Automattic/WP-Job-Manager/blob/e9256aa03c9a7e9ad1c37fd186de81dbdc149038/templates/job-filters.php#L39

I understand where it comes from and that it was an easy decision here: https://github.com/Automattic/WP-Job-Manager/pull/1708 but not all the themes are using the filters or the Search button on a second row. For example, I have to overwrite the template just to remove this one line only to accomplish a layout like this: Screenshot 2019-06-12 at 19 17 53

Maybe a padding-bottom, or a boolean based filter, would be more useful rather than resetting the entire float row.

Not a big issue, as I said, themes could overwrite the template, but maybe we can elegantly solve this, without the need of maintaining a template version for just one line.

Cheers

Steve98796 commented 5 years ago

I use the Jobify theme which has this issue. Since the update I get this mess rather than the one line I had before with no Search Jobs (as above): image

richardmtl commented 5 years ago

@Steve98796 Your issue is distinct. Note that the Jobify theme will soon be updated to fix this, but you can fix it yourself by adding this line to a code snippet to your site (I suggest using this plugin: https://wordpress.org/plugins/code-snippets/ )

add_filter( 'job_manager_job_filters_show_submit_button', '__return_false' );

Steve98796 commented 5 years ago

Thank you. I had an email just this morning announcing an update to the Jobify theme. Haven’t had chance to try it or look what it’s fixed yet. Hopefully later. I’ll let you know.