search

Automattic / WP-Job-Manager

Manage job listings from the WordPress admin panel, and allow users to post jobs directly to your site.
https://wpjobmanager.com
GNU General Public License v3.0
901 stars 368 forks source link

Filled job appears in feed #1994

Closed alexsanford closed 4 years ago

alexsanford commented 4 years ago

When a job listing is Filled, it still shows up in the Feed at ?feed=job_feed, despite the "Hide filled listings" setting being enabled.

This was mentioned in https://github.com/Automattic/WP-Job-Manager/issues/1149 (which has since been closed) and the solution alluded to was that setting. It appears that this was never fixed for the feed (or has been broken again since then).

To Reproduce Steps to reproduce the behavior:

  1. Create a job listing and set it to "Filled" (you may use the "Position Filled" checkbox on the Edit Job page for this).
  2. In Job Listings > Settings > Job Listings, check the "Hide filled positions" checkbox and click "Save Changes".
  3. Visit ?feed=job_feed
  4. Notice that the filled job listing appears in the feed.

Expected behavior

I do not expect to see the filled position in the feed.

dericleeyy commented 4 years ago

2883810-zen

collegelifenl commented 4 years ago

Just to double check: the issue has been fixed? Kristian Voldrich Founder & Managing Director College Life m: +31 (0)6 1933 1671 w: collegelife.co e: kristian@collegelife.co https://facebook.com/collegelifenl https://twitter.com/collegelifenl https://www.linkedin.com/company/13031568/ https://www.linkedin.com/posts/kristianvoldrich_collegelife-raawards2019-employerbranding-activity-6607204772741292032-INa4

On Sun, 26 Apr 2020 at 14:41, Jake Oehler Morrison notifications@github.com wrote:

Closed #1994 https://github.com/Automattic/WP-Job-Manager/issues/1994 via #1999 https://github.com/Automattic/WP-Job-Manager/pull/1999.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Automattic/WP-Job-Manager/issues/1994#event-3272904329, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTBVCGW3TVXC5NFIYLXL53ROQTXLANCNFSM4MJ5S3MA .

jom commented 4 years ago

@collegelifenl It has been merged into master, but the fix hasn't been released. No ETA at this time.