Bound listing duration between 1 and 100 years, or no expiration

[thedebian]

Fixes #2690

Changes Proposed in this Pull Request

This PR fixes an issue with the listing duration being a free text setting. It is now a number, bound from 1 to 100 years. If a number if below or above, it will be reset to "no expiration". It's also adding a placeholder "No limit" to the field.

Testing Instructions

• Don't apply PR
• Follow test steps in #2690
• Should break
• Apply PR
• Do it again
• ✅ It should be set to "no limit"
• Update limit to a number between 1 and 36500
• ✅ The limit should be properly set
• Update it to a number out of these bounds (eg. 0, -1, 36501)
• ✅ It should be set to "no limit"
• The field should also only accept numbers, you can try manually setting the field to some random text (you'll have to bypass browser submit checks), it should be set to "no limit"

---

Plugin build for 008c0fbb1105b54c53cac9be799d70300cdb4b08
📦 Download plugin zip
▶️ Open in playground

[thedebian]

Looks good. Could the same issue happen with the 'Listing Limit' setting? Looks like I can even save it as a string:

Good catch, I'll check other settings and update them too 👍