Refactor WPJM Data Cleaner to use constants everywhere

Automattic / WP-Job-Manager

Manage job listings from the WordPress admin panel, and allow users to post jobs directly to your site.

https://wpjobmanager.com

GNU General Public License v3.0

895 stars 366 forks source link

Closed fjorgemota closed 6 months ago

fjorgemota commented 6 months ago

Follow-up to #2719

Use private const instead of private static to save the properties of the WP Job Manager Data Cleaner class, for consistency

Check if the tests still pass
Check if you can disable/uninstall the plugin correctly while having the option to clean your data enabled

Plugin build for e1c4b08d56ef828f1bc84c81f2a4fd26e52d271d
📦 Download plugin zip
▶️ Open in playground

fjorgemota commented 6 months ago

@pgk Thanks for your review and suggestion! I just did what you suggested, do you think it needs an additional review?