Repair edit job listing screen.

[gikaragia]

Oveview

This fixes an issue to the edit job listing screen. To reproduce:

1. Create a job and publish it
2. Set up a recaptcha and enable it in the settings (any version will do, go to https://www.google.com/recaptcha to create keys if you don't have some already)
3. Go to the job dashboard
4. Edit the job
5. After doing some change try to save the listing
6. At this point the update fails and nothing happens

The problem was that we added the actions to the WP_Job_Manager_Recaptcha constructor. This way the hooks were added even when we wanted to call utility methods and the captcha was also enqueued to the dashboard page.

Changes Proposed in this Pull Request

• I moved the hook registration from the constructor to equeue_scripts. This way we only enqueue the captcha when we need to.

Testing Instructions

• Test together with: https://github.com/Automattic/wpjm-addons/pull/481
• Follow the steps from the overview and observe that nothing is broken now.
• Also try testing recaptcha functionality in general to ensure that nothing else is broken.
• Additionally, we should test how the changes in reCAPTCHA work in relation to different plugin versions:
  • The newest version of the paid plugins should work with the previous version of WPJM (i.e. 2.2.2) but with v2 reCAPTCHA only
  • The previous versions of the paid plugins should work with latest version of WPJM but with warnings printed as we deprecated the old methods.

---

Plugin build for 42aae9cb2f587f2da93c4d5984a20c00db365607
📦 Download plugin zip
▶️ Open in playground