search

Automattic / WP-Job-Manager

Manage job listings from the WordPress admin panel, and allow users to post jobs directly to your site.
https://wpjobmanager.com
GNU General Public License v3.0
900 stars 368 forks source link

Accessible Issue / Missing Aria-Label for input field #2825

Closed masteradhoc closed 2 months ago

masteradhoc commented 4 months ago

Describe the bug The following line seems to be missing an aria-label. Gets flagged by tools like https://wave.webaim.org/

https://github.com/Automattic/WP-Job-Manager/blob/fa43c7624b1901cb17089a0b6593d7bba8a6fa9c/templates/job-filters.php#L31

Screenshots image

Expected behavior 1) Field should have a aria-label 2) String should be translateable

mikeyarce commented 2 months ago

There are labels there for the fields, so this looks like a false positive. https://github.com/Automattic/WP-Job-Manager/blob/fa43c7624b1901cb17089a0b6593d7bba8a6fa9c/templates/job-filters.php#L29-L32