search

Automattic / WP-Job-Manager

Manage job listings from the WordPress admin panel, and allow users to post jobs directly to your site.
https://wpjobmanager.com
GNU General Public License v3.0
900 stars 368 forks source link

The feed including the jobs get Error: invalid feed #841

Closed mpanagiotis closed 7 years ago

mpanagiotis commented 7 years ago

What I Expected To Happen

Just before udating the WordPress to the latest version 4.7 the feed=job_feed working just fine including the jobs. After the update the feed has been broken and an error occured

What Happened Instead

After update WordPress to version 4.7 Error: invalid feed

Steps to Reproduce the Bug

http://www.jobseeker.gr/?feed=job_feed

kraftbj commented 7 years ago

The only way I could duplicate this was when there were no jobs available at all. I'm continuing to look. I had one other report of this this morning via the Indeed job feed integration, but overall not being reported yet.

mpanagiotis commented 7 years ago

Another point which confirms that there is a issue with the job feed, is that Indeed stopped including my jobs from the day i was update the WordPress to 4.7. http://www.jobseeker.gr/?feed=job_feed&posts_per_page=all Still looking for a fix but with no luck.

kraftbj commented 7 years ago

@mpanagiotis Yeah, I'm looking into that too. The Indeed feed is different (assuming you're using that add-on and the indeed-job-feed feed).

mpanagiotis commented 7 years ago

@kraftbj No i am not using the Indeed add-on. After contact with Indeed I send the default job feed for including my jobs. This is the address http://www.jobseeker.gr/?feed=job_feed&posts_per_page=all But as i told you after the udate newer jobs not including.

giorgiostar commented 7 years ago

I am having the same issue. Using jobify theme and indeed job manager plugin.

edbeecroft commented 7 years ago

Can also confirm this issue after upgrading to 4.7. Using the Indeed Plugin the feed /indeed-job-feed feed is not working, and neither is /?feed=job_feed

Thanks,

Ed

spencerfinnell commented 7 years ago

@kraftbj Having users report this as well. Haven't had time to look in to it myself but getting multiple tickets. Will try to investigate soon.

spencerfinnell commented 7 years ago

Relevant: https://core.trac.wordpress.org/ticket/39157

However only when there are no posts as @kraftbj mentioned.

aheckler commented 7 years ago

3008576-t

mpanagiotis commented 7 years ago

Any update info about the issue? I have just update to version 4.7.2 but still the feed not working.

edbeecroft commented 7 years ago

Echo that.

rampling commented 7 years ago

Echo that again, we really need an answer to this please Dev.... is is resolved and can we upgrade or not please...????

edbeecroft commented 7 years ago

we rely quite heavily on the feeds for traffic, so this is more than just an inconvenience now. A response would be great - it has been two months now, and I'm sure I'm not the only one on an annual subscription. Thanks!

dbtlr commented 7 years ago

@edd677, @mpanagiotis I'm currently trying to reproduce this, but having some trouble do so.

If I could get an error log and/or a list of installed plugins that could be helpful. Otherwise, without more information, we're not going to be able to fix this.

For clarities sake, for testing I'm running: WordPress 4.7.2 and WPJobManager@master w/ the 2017 theme.

As with everyone else, I can only reproduce this with an empty feed and that appears to be a core error, not a WPJM error. However, in looking at jobseeker, it seems clear to me that this is not the source of the error since they have jobs posted on their site.

spencerfinnell commented 7 years ago

Delete your blog posts and you will see it.

dbtlr commented 7 years ago

It appears that core changed the loading of feeds to be dependant on a has_posts check. Adding the post_type=job_listing to the query args will fix the page load now.

I've submitted PR #870 which adjusts the query and adds this by default when loading this feed type. Would love a confirmation that this PR fixes your guys' issues before I merge it.

edbeecroft commented 7 years ago

@dbtlr - At first I wasn't sure what you wanted me to do, but I appended &post_type=job_listing to the section after the domain in the URL /?feed=job_feed&job_types=contract-temp%2Cfreelance%2Cinternship%2Cpart-time%2Cpermanent&search_location&job_categories&search_keywords, and this seems to have fixed it.

A perhaps related issue - With the Indeed Integration plugin, the following is producing an invalid feed:

All jobs which are published and non-filled will be included in your feed, and when enabled it will be found at yoursite.com/indeed-job-feed/. yoursite.com/indeed-job-feed/ is reporting an invalid feed.

dbtlr commented 7 years ago

That confirmation should be good enough, that the post_type not being set was indeed your issue. Thanks!

mpanagiotis commented 7 years ago

I also want to confirm that adding the post_type=job_listing to the job feed fix the issue. As you can see http://www.jobseeker.gr/?feed=job_feed&post_type=job_listing&posts_per_page=all