Redirects: Support non-ASCII characters

Automattic / WPCOM-Legacy-Redirector

WordPress plugin for handling large volumes of legacy redirects in a scalable manner.

20 stars 16 forks source link

Redirects: Support non-ASCII characters #92

Closed GaryJones closed 4 months ago

GaryJones commented 3 years ago

Emojis and characters like the horizontal ellipsis … could be submitted successfully in the FROM path's, but they didn't actually redirect because the subsequent lookup wasn't handling things correctly.

props @ovidiul.

Fixes #42.

GaryJones commented 3 years ago

Tests pass, but I think it would be worth doing some manual testing for this as well.

ovidiul commented 3 years ago

Hi @GaryJones , manual tests seem to run fine at this point, one thing that confuses me it's the interface related to issue #73 which I plan to fix next.

Would you have any suggestions before merging this?

GaryJones commented 4 months ago

Closing in favour of the now-merged #102.