Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.96k stars 3.12k forks source link

Remove Microformat Classes from CSS #1268

Open davidakennedy opened 6 years ago

davidakennedy commented 6 years ago

I wanted to create an issue to fix some of the issues related to errors with structured data.

We talked about these issues as a team, and adding extensive support for Microformats 2 or Schema.org through microdata or RDFa doesn't make much sense because of:

Going forward:

PRs welcome on removing all Microformat classes from the Sass/CSS files.

Related issues and PRs for reference:

844

860

930

1065

1113

dshanske commented 6 years ago

I disagree with this decision, but based on it, I strenuously object to endorsing JSON-LD as it is inconsistent. If you want to make this statement, it should be that _s will have no structured markup of any sort and that is to be added to any theme developed on it by the theme author.

davidakennedy commented 6 years ago

Thanks for speaking up, @dshanske!

I disagree with this decision, but based on it, I strenuously object to endorsing JSON-LD as it is inconsistent.

How is it inconsistent? That would help me understand better.

If you want to make this statement, it should be that _s will have no structured markup of any sort and that is to be added to any theme developed on it by the theme author.

Would be fine with that. I wasn't intended to add it to any official docs.

dshanske commented 6 years ago

Deciding that you will remove all structured markup but then recommending a different type of markup. I would rather if you are going in that direction, that you make the statement that structured markup is up to the individual who creates the theme based on _s.

grappler commented 6 years ago

@dshanske How is JSON-LD inconsistent? It seems like Yoast SEO thinks it is OK. https://yoast.com/json-ld/

dshanske commented 6 years ago

@grappler I think you meant me. But, I'm saying it is inconsistent with the decision not to support structured data. If you are rejecting one over the other, I would object.

grappler commented 6 years ago

I think you meant me. But, I'm saying it is inconsistent with the decision not to support structured data.

Yes, sorry. Ah I thought you meant JSON-LD was inconsistent and not the decision to point theme authors toward JSON-LD.

Deciding that you will remove all structured markup but then recommending a different type of markup.

We are not removing the structured markup but removing the use of the classes from the CSS. The only change that is required is to remove .hentry from the CSS and replace it with .post,.page. I hope that clarifies it a bit.

miklb commented 6 years ago

Is this still planned?