Remove unnecessary aria-expanded attribute on ul

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.

http://underscores.me/

GNU General Public License v2.0

10.96k stars 3.12k forks source link

Remove unnecessary aria-expanded attribute on ul #1303

Closed jaredcaraway closed 4 years ago

jaredcaraway commented 6 years ago

Changes proposed in this Pull Request:

Remove aria-expanded attribute from <ul> element, as it should only be applied to the button controlling the showing/hiding of the menu. (See my comment on #1289 for more detail.)

Related issue(s):

Fixes https://github.com/Automattic/_s/issues/1289

Ismail-elkorchi commented 4 years ago

I removed one more instance of aria-expanded from the<ul> element that was introduced after the merging of https://github.com/Automattic/_s/pull/1379, and rebased the branch on master so the Travis test suite pass.