Closed sterndata closed 4 years ago
I just came across this as IE11 rendered the sidebar over the content using this template. And I don't think using 75% with 0 margin does accomplish the same thing. I had the same idea, but 75% width just fixes it for IE as it calculates 75% of the whole site. Chrome for example uses 75% of the "correct" container size, creating 25% space between sidebar and content. The actual fix for IE would be adding display: block; to .site-main I guess.
Thanks @sterndata, @jj-wd for your suggestions. I am going to close this issue since the negative margins were removed in https://github.com/Automattic/_s/pull/1251.
The layout for content-sidebar is
This causes problems in old browsers. Changing that to
seems to accomplish the same thing. Are the negative margins necessary? If not, should I make the changes and do a PR?