search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.96k stars 3.12k forks source link

Improved font rendering on OS X #1347

Closed LorincJuraj closed 4 years ago

LorincJuraj commented 5 years ago

Changes proposed in this Pull Request:

Some fonts (e.g. Google's Roboto) look much thicker on OS X because of different font rendering. This can be fixed by following code: -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale;

As far as I know there are no performance issues related to this.

More about alleged readability decrease is mentioned following Material Components issue discussion. (TL;DR: removing -webkit-font-smoothing:antialiased was marked as wontfix).

Ismail-elkorchi commented 4 years ago

Thank you @LorincJuraj fo the Pull Request. As per usabilitypost.com :

Feel free to use it (font smoothing) on light text on dark backgrounds, feel free to use it to fix custom font rendering on Windows or to style specific bits of text on the page to make it look more slender, but for main portions of text where readability is paramount please leave the default setting alone and let the operating system handle the smoothing.

Consequently, I am going to close this issue.

LorincJuraj commented 4 years ago

Thank you @LorincJuraj fo the Pull Request. As per usabilitypost.com :

Feel free to use it (font smoothing) on light text on dark backgrounds...

Thanks for the link. I learned something new and useful.

Ismail-elkorchi commented 4 years ago

It's a pleasure @LorincJuraj.