search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.96k stars 3.12k forks source link

'posted_on' and 'by' translation #1365

Closed guillaumegautier closed 4 years ago

guillaumegautier commented 5 years ago

Hello, I know those two strings have already been corrected but... _s is a theme meant to be hacked and I added some new strings for translation. So i added my sources in Poedit, my new strings appear and are translated but the two 'Posted_on %s' and 'by %s' are detected but not working. Is there another way to code them so the generated .po and .mo work ?

Of course if I use .pot, it works but I dont have my new translatable strings.

Capture d’écran 2019-07-09 à 17 20 16

Ismail-elkorchi commented 4 years ago

Thank you @guillaumegautier for the issue report.

It seems that the .pot file wasn't updated since https://github.com/Automattic/_s/pull/1119. This PR https://github.com/Automattic/_s/pull/1395 should address this.

If you use the latest version of _s and you have composer installed, you can update the .pot file after modifying the theme's text by running the commands composer install then composer make-pot in the terminal.