search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.96k stars 3.12k forks source link

Remove removed PHPCS rule #1374

Closed szepeviktor closed 4 years ago

szepeviktor commented 5 years ago

to fix CI

was https://travis-ci.org/Automattic/_s/jobs/492470379#L600

szepeviktor commented 5 years ago

much better: https://travis-ci.org/Automattic/_s/jobs/586252288#L620-L663 now there are only small style errors

szepeviktor commented 5 years ago

@crunnells Automattic decided to halt _s developement?

jrfnl commented 5 years ago

@szepeviktor Please see #1311

Regarding the specific sniff: the sniff has not been removed, but has been renamed. Though instead of updating the name in the ruleset, it would be better to switch to PHPCompatibilityWP instead (which is what is done in #1311, though that PR is very out of date and I have little motivation to update it as PRs in this repo are being left to rot instead of being merged).

Ismail-elkorchi commented 4 years ago

@szepeviktor Thank you for the PR and for your willingness to contribute to this project. As Juliette said, the changes regarding this sniff must be done in https://github.com/Automattic/_s/pull/1311. So I'm going to close this PR.

@jrfnl If you have the time, the motivation and the energy to update https://github.com/Automattic/_s/pull/1311, I'd be willing to review it and then merge it promptly.

szepeviktor commented 4 years ago

Thank you.

jrfnl commented 4 years ago

@Ismail-elkorchi Working on WPCS 3.0 for the moment, let's update that PR after the that's done so it is ready for the future.

Ismail-elkorchi commented 4 years ago

@jrfnl That's really awesome. Thank you for your great work.