search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.94k stars 3.12k forks source link

Close small menu when user clicks outside #1375 #1379

Closed GitarMan closed 4 years ago

GitarMan commented 4 years ago

Changes proposed in this Pull Request:

When small (mobile) menu is toggled open, this feature closes the menu when the user taps or clicks outside the #site-navigation container variable.

Related issue(s):

Fixes #1375

currentcreative commented 4 years ago

I'm sorry to ask a stupid question, but what does the notice mean that "all checks have failed"? here: https://travis-ci.org/Automattic/_s/builds/609127585?utm_source=github_status&utm_medium=notification

philiparthurmoore commented 4 years ago

@currentcreative It means that there is either an error here or here. Basic sniffing that needs to be updated for the automated commit tests.

philiparthurmoore commented 4 years ago

Or it means that there really is a code sniff problem that needs to be fixed by the committer.

philiparthurmoore commented 4 years ago
2019-12-22_09-33-46 2019-12-22_09-33-23
philiparthurmoore commented 4 years ago

Looks like the sniff files need to be updated.

jrfnl commented 4 years ago

@philiparthurmoore See #1311

GitarMan commented 4 years ago

Just saw all this, thanks for changing the indentation. Glad I was able to contribute!

Ismail-elkorchi commented 4 years ago

It's all my pleasure @GitarMan 🎉