search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.94k stars 3.12k forks source link

Removing Built and Test files? #1392

Closed hanneslsm closed 4 years ago

hanneslsm commented 4 years ago

Thanks @Ismail-elkorchi for breathing life back into the project!

I'm not sure about the built and test files like package.json, travis, et cetera. For me underscores is perfect, because it has much less clutter than other starter themes, so I'd have to delete them first and use my files.

What do you think?

Ismail-elkorchi commented 4 years ago

Hello @HannesDev and thank you for the feedback.

Introducing build tools to _s was discussed heavily in https://github.com/Automattic/_s/issues/1149.

In short, these tools allow to automate some of the pain points of maintaining this project, like compiling SCSS files to CSS and forcing the project files to follow the WordPress coding standards.

I'm pretty sure issues likes https://github.com/Automattic/_s/issues/615, https://github.com/Automattic/_s/pull/1382, https://github.com/Automattic/_s/pull/932, https://github.com/Automattic/_s/pull/1168 and many others were the result of lacking these tools.

hanneslsm commented 4 years ago

Thanks for the answer. So, you include built tools but also stripped down to it's essentials. Do I get that right?

Ismail-elkorchi commented 4 years ago

So, you include built tools but also stripped down to it's essentials. Do I get that right?

Yes, that was the idea. To include a simple workflow for automating some basic tasks while keeping the barrier to entry as low as possible.

hanneslsm commented 4 years ago

Got it, thanks.