search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.94k stars 3.12k forks source link

Declare HTML5 scripts and styles support for better compliance with W3C validator #1401

Closed audrasjb closed 4 years ago

audrasjb commented 4 years ago

Changes proposed in this Pull Request:

Hi,

Given this theme is written in HTML5, it should declare HTML5 support for styles and script to avoid using type attributes in styles and scripts.

Otherwise, W3C validator will throw a warning because of the type element.

This option was introduced in WordPress 5.3. For reference, see:

Related issue(s):

Fixes #1400

Ismail-elkorchi commented 4 years ago

And by the way, it seems like your commit email isn't defined or is wrong, because the commit you've just pushed appear to have two authors.

You can set it up simply by typing in the command line git config --global user.email "your@email.com"

audrasjb commented 4 years ago

Ow! Nice catch, thank you @Ismail-elkorchi !