search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.93k stars 3.12k forks source link

Use stylelint and eslint directly #1408

Closed neilabraham closed 4 years ago

neilabraham commented 4 years ago

Changes proposed in this Pull Request:

@wordpress/scripts is a huge package with some huge dependencies, but it's only being used for linting, which are just tiny wrapper scripts around stylelint and eslint.

I propose to use stylelint and eslint directly. This reduced npm install time from 3 minutes down to 15 seconds on my computer.

Related issue(s):

neilabraham commented 4 years ago

Hmm, _s fails with the latest version of stylelint-config-wordpress (16.0.0). @wordpress/scripts uses 13.1.0, but 15.0.0 seems to work here.

Ismail-elkorchi commented 4 years ago

Hi @neilabraham thanks for looking at this.

I agree with you that we don't use all the dependencies in @wordpress/scripts, although we may use more of them. The main reason why I used @wordpress/scripts in the first place is to reduce the number of dependencies that the project relies on as this was one of the main goals that were agreed on in https://github.com/Automattic/_s/issues/1149.

I am inclined to keep this as it is for the moment.