text_domain in phpcs.xml.dist not correctly set using underscores.me

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.

http://underscores.me/

GNU General Public License v2.0

10.93k stars 3.12k forks source link

text_domain in phpcs.xml.dist not correctly set using underscores.me #1476

Open onlyhumans-dev opened 3 years ago

onlyhumans-dev commented 3 years ago

When choosing a theme name in the underscores.me website, the text_domain does not get replaced in:

<rule ref="WordPress.WP.I18n">
  <properties>
    <property name="text_domain" type="array" value="_s"/>
  </properties>
</rule>

Which results in a giant list of "Mismatched text domain. Expected '_s' but got ..." errors when running "composer lint:wpcs"