Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.93k stars 3.12k forks source link

Mobile submenu issues #1485

Open derbra1513 opened 3 years ago

derbra1513 commented 3 years ago

First off thanks for the amazing starter template, its worked well for a project I am working on and will likely us it for future ones.

I am having an issue with the mobile menu and sub menu links not being clickable. I have attached a link below for a sample. https://boonmultimediadesign.com/demos/rts/managed-services-2/

The mobile menu doesn't not work with any sub-menu links. For some reason the "focus" class gets toggled first closing the menu and prevents the link from actually loading. I have documented this issue with the following devices.

  1. Desktop Safari
  2. Desktop Chrome
  3. Desktop Firefox
  4. Android Devices

The menu does work as intended on iOS safari and chrome.

Thank you so much for your help, I've tried searching through the open/closed issues without any success on finding a solution.

Libraries I am using

LukaszJaro commented 3 years ago

Check chrome developer console, you have errors.

Tetradev commented 1 year ago

Although, reading articles here, understanding that the project is no longer being continued. I'd like to comment on this one, since i tripped over the same issue.

Also finding out that removing:

event.preventDefault();

from the navigation.js basically solved the issue. Looking with the developer console, it still toggles the focus classes. So i wonder if this command is really needed.