search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.95k stars 3.12k forks source link

fix post date bug #1489

Closed iamdavidabayomi closed 3 years ago

iamdavidabayomi commented 3 years ago

Changes proposed in this Pull Request:

i choose to use underscore as the based theme for a new client theme and found out that the posted on date outputted two markup date once i change/modified the post. So a peep into the underscore posted on function i found out that there is a code block outputting both the published and modified date if the published date is not equal to the modified date.

So i assumed that the proposed behaviour is that if the published date is not equal to the modified date then output the modifed date.

zimnyd commented 3 years ago

It nothing wrong with that. It's a clear info for robots when post was published and when updateed. On front we only need one of them - when the post was updated. To do that we can use of CSS code:

// entry-date display only update time
time.published:not(.updated) {
    display: none;
}
iamdavidabayomi commented 3 years ago

It nothing wrong with that. It's a clear info for robots when post was published and when updateed. On front we only need one of them - when the post was updated. To do that we can use of CSS code:

// entry-date display only update time
time.published:not(.updated) {
  display: none;
}

Okay seems i did not check that. Thanks