search

Automattic / _s

Hi. I'm a starter theme called _s, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.
http://underscores.me/
GNU General Public License v2.0
10.93k stars 3.12k forks source link

node-sass has been deprecated #1491

Open andromaque opened 3 years ago

andromaque commented 3 years ago

Node Sass has been deprecated in October 2020 (https://sass-lang.com/blog/libsass-is-deprecated) Now the recommendation is to use "sass" instead of "node-sass".

We have environments where node-sass is not present anymore, and it's not possible to use underscores themes because they are still using node-sass.

Is it planned to update it?

GenieTim commented 3 years ago

The update is rather doable:

Run the following commands:

yarn remove node-sass
yarn add --dev sass

and adjust the build scripts in package.json from node-sass sass/ -o ./ to sass sass/:./ and node-sass sass/ -o ./ --source-map true --output-style expanded --indent-type tab --indent-width 1 -w to sass sass/:./ --source-map true --output-style expanded --indent-type tab --indent-width 1 -w.

gomarion commented 3 years ago

I came across this problem today and tried the commits made by @vjandrea. I was able to successfully run a working WATCH script, but the "sass" package (replacement of node-sass) from NPM only gave me more issues when compiling. I ended up installing NVM and then install the latest usable versions of NPM and Node JS which are 6.14.8 and v14.14.0. WATCH script is working fine for my project again.