Automattic / a8c-ci-toolkit-buildkite-plugin

A caching plugin that can be invoked from your build script.
22 stars 5 forks source link

Comment with dependency diff #120

Closed wzieba closed 2 months ago

wzieba commented 2 months ago

Description

This PR introduces comment_with_dependency_diff script that is aiming to help Android product teams to better understand what changes to the dependency tree a PR might introduce.

We use similar scripts in WooCommerce and Day One projects. I want to extend support to other projects and share the implementation between them for easier maintenance.

Additionally, this PR introduces some improvements to the script:

To see the result, please see:


wzieba commented 2 months ago

Thank you @AliSoftware for the review! You raised good points. I think I've adjusted the implementation. Here are also updated tests:

Both seem to still work fine.

wzieba commented 2 months ago

Correction, title is missing

image
wzieba commented 2 months ago

We're back on track!

image

https://github.com/Automattic/Matticspace-Mobile/pull/67

AliSoftware commented 2 months ago

I just realized that there might be more to it to compute the exact comment body length, because:

Maybe the easiest solution is to simply reduce the value of github_comment_max_size in your code to something like 65400, to give some margin for those extras characters and id comment?