Closed wzieba closed 2 months ago
Thank you @AliSoftware for the review! You raised good points. I think I've adjusted the implementation. Here are also updated tests:
Both seem to still work fine.
Correction, title is missing
We're back on track!
I just realized that there might be more to it to compute the exact comment body length, because:
\n
as a character (i.e. comparing with the current length + length of header + length of body is off by one or two due to the extra newlines)comment_on_pr
also adds some hidden content (<!-- … -->
that includes the comment ID (--id
), so that subsequent calls (from subsequent CI builds on the same PR) can know which comment to edit / delete. So that adds a bit to the length as wellMaybe the easiest solution is to simply reduce the value of github_comment_max_size
in your code to something like 65400, to give some margin for those extras characters and id comment?
Description
This PR introduces
comment_with_dependency_diff
script that is aiming to help Android product teams to better understand what changes to the dependency tree a PR might introduce.We use similar scripts in WooCommerce and Day One projects. I want to extend support to other projects and share the implementation between them for easier maintenance.
Additionally, this PR introduces some improvements to the script:
To see the result, please see:
CHANGELOG.md
if necessary.