Clarify filter names around creating empty translations

Automattic / babble

Multilingual WordPress done right.

245 stars 50 forks source link

Clarify filter names around creating empty translations #219

Open simonwheatley opened 9 years ago

simonwheatley commented 9 years ago

Currently all Babble filters and actions are prefixed with bbl_ except babble_create_empty_translation which is an action triggered by an immediate cron job in order to asynchronously create the empty translations.

simonwheatley commented 9 years ago

Proposal:

[x] Change bbl_create_empty_translations to bbl_trigger_create_empty_translations
[x] Change babble_create_empty_translations to bbl_cron_create_empty_translations

See:

https://github.com/Automattic/babble/blob/49a5140dbb8caf56e932c41f66674b6e9aebbb85/class-jobs.php#L1130-L1138
https://github.com/Automattic/babble/blob/feature/publish-prior-to-translation/translation-show-pre-translation.php
https://github.com/Automattic/babble/pull/213/

simonwheatley commented 9 years ago

Looks like there may be some issues with fallback content when using the API functions, as exposed by the tests added in https://github.com/Automattic/babble/commit/81090bc2e24d1f8b9b502b5bf2429efde5816d1b. :worried: