search

Automattic / babble

Multilingual WordPress done right.
https://wordpress.org/plugins/babble/
245 stars 50 forks source link

Use `$url` parameter in `bbl_locale::home_url()`? #221

Closed simonwheatley closed 9 years ago

simonwheatley commented 9 years ago

Investigate whether the home_url method in class-locale.php can operate on the $url parameter instead of the returned value from the get_option call.

Check this does not break compatibility with WordPress multisite in a subdirectory mode.

johnbillion commented 9 years ago

Looks like I hadn't commented here, but the tests introduced in #279 demonstrate that the $url parameter cannot be used. If it's changed, the tests fail.