search

Automattic / babble

Multilingual WordPress done right.
https://wordpress.org/plugins/babble/
245 stars 50 forks source link

We hook into `pre_update_option_rewrite_rules` which is probably suboptimal #233

Closed simonwheatley closed 9 years ago

simonwheatley commented 9 years ago

Currently we hook into the pre update filter on the rewrite_rules option on Babble_Locale::internal_rewrite_rules_filter(), which is a little suboptimal.

Instead we should use the rewrite_rules_array filter to make our changes.

johnbillion commented 9 years ago

IIRC the pre update filter is used rather than rewrite_rules_array to ensure Babble hooks in as late as possible. A late priority on rewrite_rules_array should be sufficient though.