Automattic / babble

Multilingual WordPress done right.
https://wordpress.org/plugins/babble/
245 stars 50 forks source link

Add filter `home_url` – why is this here? #235

Closed simonwheatley closed 9 years ago

simonwheatley commented 9 years ago

See:

Questions:

simonwheatley commented 9 years ago

Also look at whether the home_url filtering, in the Babble_Locale class, is actually optimal.

simonwheatley commented 9 years ago

Fixed line references in the issue description by referencing a specific commit version of the file

joehoyle commented 9 years ago

From what I understand, these filters are needed as illustrated by the above Pull Request for the behat test. However, perhaps we wan't to just comment the code a bit better?

joehoyle commented 9 years ago

I've added more docs to the hooked functions in #315 to explain why the filters are there.

joehoyle commented 9 years ago

@simonwheatley over to you to merge #315 which should conclude this issue.