Automattic / babble

Multilingual WordPress done right.
https://wordpress.org/plugins/babble/
245 stars 50 forks source link

Object cache the results of getting translation jobs #266

Closed joehoyle closed 9 years ago

joehoyle commented 9 years ago

We now grab all the jobs for an object at once regardless of status, then filter them later. This way we get a much better cache hitrate.

Also added invalidation on deleting a job and creating jobs for a post.

See #234

simonwheatley commented 9 years ago

This looks good. Are there any tests it's appropriate to add here?

Let's wait until #271 is merged before merging this.

joehoyle commented 9 years ago
simonwheatley commented 9 years ago

@joehoyle bump

joehoyle commented 9 years ago

@simonwheatley @johnbillion it seems we are running tests twice right now, once for pull-requests and once for each branch, that means we have two builds on every pull-request. On other projects, I've typically turned off the "test every branch" option in Travis, so we only have to have the single PR build.

Other than that - this PR should be good to go, added tests!

simonwheatley commented 9 years ago

@joehoyle @johnbillion Can you please refresh the branch so it will merge cleanly, please?

joehoyle commented 9 years ago

@simonwheatley done! just waiting for the build.

joehoyle commented 9 years ago

Doh, I guess there was some pretty big changes merged in. I'll take a look at this tomorrow.

simonwheatley commented 9 years ago

@joehoyle Thanks! :smiley:

joehoyle commented 9 years ago

@simonwheatley phew, got there! I think the merge from develop didn't bring the add_action changes with it. Passing now.