Reduce dependency on Babble_Plugin class

Automattic / babble

Multilingual WordPress done right.

https://wordpress.org/plugins/babble/

245 stars 50 forks source link

Reduce dependency on Babble_Plugin class #314

Closed johnbillion closed 9 years ago

johnbillion commented 9 years ago

See #222.

Blocked by #312.

This greatly simplifies and reduces the dependency on the Babble_Plugin class, but doesn't remove it entirely. Babble_Jobs, Babble_Languages, Babble_Switcher_Interface, and BabbleTranslationGroupTool use its render_admin() and get_option() methods.

If I have time later today I'll revisit this and see about converting Babble_Plugin to a static class.

simonwheatley commented 9 years ago

Behat tests in 5.6 are failing…?

joehoyle commented 9 years ago

See #285 for the failing tests, it's not limited to this PR

joehoyle commented 9 years ago

@simonwheatley tests now passing, ready for a review/merge.

simonwheatley commented 9 years ago

@joehoyle @johnbillion Can you please refresh this PR, so it can be merged cleanly.

joehoyle commented 9 years ago

@simonwheatley done - will just need to let the build finish.

simonwheatley commented 9 years ago

Thanks again @joehoyle @johnbillion