search

Automattic / babble

Multilingual WordPress done right.
https://wordpress.org/plugins/babble/
246 stars 50 forks source link

add isset query_vars s to front page check #331

Closed richaber closed 9 years ago

richaber commented 9 years ago

Please see issue #330 "When a static front page is configured, the Appearance Menus Screen and search functionality are negatively impacted."

simonwheatley commented 9 years ago

The PHPUnit tests for this PR are failing, but I have a possible fix in #333.

@richaber Once #333 is merged into develop, please pull the develop branch from here into your develop branch at https://github.com/richaber/babble/tree/develop, and that should mean that the PHPUnit tests will pass on this PR.

We will then need a PHPUnit test to demonstrate the issue reported in #330, i.e. a test which fails before your fix and then passes afterwards. Having this test will allow us to detect regressions in the future. :smiley:

simonwheatley commented 9 years ago

@richaber Where are my manners? Thank you for submitting an issue and a PR to address it! :grinning:

simonwheatley commented 9 years ago

Closing this in favour of #334