search

Automattic / block-experiments

A monorepo of Block Experiments
125 stars 17 forks source link

Layout Grid: Contents in the Layout Grid block are being excluded from the excerpt #245

Closed danieldudzic closed 2 years ago

danieldudzic commented 2 years ago

This has been originally reported here: https://github.com/Automattic/wp-calypso/issues/54046

I was able to track the issue down to the excerpt_allowed_wrapper_blocks array.

I don't know if the Layout Grid contents are being intentionally excluded from the excerpt generation - if that's not the case, we should probably allow it, as it is confusing users.

'jetpack/layout-grid', 'jetpack/layout-grid-column', should be added to the list via excerpt_allowed_wrapper_blocks filter.

supernovia commented 2 years ago

Noting in this can cause people's RSS feeds to break, and if people are using patterns much it's probably a big deal, especially if they haven't been watching their own emails / feed reader stuff (wordpress.com reader is unaffected since it ignores the excerpt setting).

johngodley commented 2 years ago

I don't know if the Layout Grid contents are being intentionally excluded from the excerpt generation

It seems strange that a block has to opt in, rather than opt out, but there was no intention here - it just wasn't something we were aware of, and doesn't seem to be mentioned anywhere in the Gutenberg handbook as a thing that needs to be done.

johngodley commented 2 years ago

I've added a note in the Gutenberg docs so that people using inner blocks are aware that excerpt_allowed_wrapper_blocks may be needed. I'm sure a lot of blocks don't do this.

https://github.com/WordPress/gutenberg/pull/36405

supernovia commented 2 years ago

Thank you!